Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][ADD] stock_picking_delivery_label_link: New module #892

Open
wants to merge 1 commit into
base: 15.0
Choose a base branch
from

Conversation

chienandalu
Copy link
Member

@florian-dacosta
Copy link
Contributor

There is a way to identify shipping label since a long time https://github.com/OCA/delivery-carrier/blob/16.0/base_delivery_carrier_label/models/shipping_label.py

I believe the base_delivery_carrier_label should be refactore to be splitted into multiple modules and one of the module would be this shipping label class.
Could we not converge toward something like this ?

@pedrobaeza
Copy link
Member

@florian-dacosta not in this stable version...

@florian-dacosta
Copy link
Contributor

@pedrobaeza Sure, but I was wondering if something similar could be done instead of doing it differently ?
I mean, we could introduce in v15 this stock_picking_delivery_label_link that would implement the shipping.label inherits instead of a many2many on pickings?
And then in v18, we could migrate it and remove this part from base_delivery_carrier_label somehow ?

I don't know what is feasible on your side, I am just wondering if we could avoid having, at term, 2 concurrent modules...

@pedrobaeza
Copy link
Member

We can converge in 18 if that ugly module is split.

@chienandalu
Copy link
Member Author

Hi @florian-dacosta precisely the intention here is to avoid pulling new deps into the current modules. For the future, a base module could add a hook, maybe a filed, and not much more IMO... for that base_delivery_carrier_label it's too bloated in its current shape...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants